Off the top of my head, I can't think of a rock musical that wasn't crap. I saw the stage musical Tommy and thought it was great. But the movie is an abomination.
For songs, I'd go with 42nd Street. For choreography, Singing In The Rain. For story... too many to mention. Favorite singer, Bing all the way. Favorite individual dancer, Eleanor Powell's stuff is breathtaking.